Fix #4037: Fix code generation for generic arrays #4046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We confused "generic" and "unbounded generic" before, which meant that AnyRef-bounded generic arrays ignored their ClassTag.
allanrenucci
approved these changes
Feb 28, 2018
| case tp: TypeParamRef => true | ||
| case tp: TypeProxy => isGeneric(tp.underlying) | ||
| case tp: AndType => isGeneric(tp.tp1) || isGeneric(tp.tp2) | ||
| case tp: OrType => isGeneric(tp.tp1) || isGeneric(tp.tp2) |
There was a problem hiding this comment.
Can you explain why for both A & B and A | B, you have isGeneric(A) || isGeneric(B)?
There was a problem hiding this comment.
It's an approximation that makes sure that the erasure would not depend on any possible instantiation of the type. Erasure of AndTypes and OrTypes is quite complex, so it's hard to come up with a narrower condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We confused "generic" and "unbounded generic" before, which meant that
AnyRef-bounded generic arrays ignored their ClassTag.